-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retreives maxlogage calling api_FTL.php #2107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTL is returning the limit in seconds. I don't see any calculation to hours in your PR...
I did't know that. |
See the terminal output of the PR description of pi-hole/FTL#1295 But best would be to try different config settings and compare to the API output. |
You're right:
and API returns this second value (https://github.com/pi-hole/FTL/blob/development/src/api/api.c#L1499-L1503). |
FTL defines MAXLOGAGE value. PHP retrieves the value and converts seconds to hours Javascript calls the API to update the value. Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
20ace3b
to
171bf81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Fixes #1825, even if the user compiles FTL with a custom MAXLOGAGE.
How does this PR accomplish the above?:
Javascript calls the API to update the title, using the FTL defined value.
What documentation changes (if any) are needed to support this PR?:
none.
PRE-REQUISITES:
This PR needs pi-hole/FTL#1295