forward destinations over time

[frankrpi3]

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated
• The issue I am reporting isn't a duplicate

How familiar are you with the codebase?:

1

---

[BUG | ISSUE] Expected Behaviour:
forward destination graphic should display all logs

http://fs5.directupload.net/images/170418/4853ocop.png

[BUG | ISSUE] Actual Behaviour:
sometimes gaps are appearing in the graphic, but pi-hole and query logging are working normal

[BUG | ISSUE] Steps to reproduce:
it appears sometimes when not so many querys have to be logged

Log file output [if available]

output

Device specifics

Hardware Type: rPi, VPS, etc
OS:

This template was created based on the work of udemy-dl.

[DL6ER]

How do you think that this should be resolved? As you say

it appears sometimes when not so many querys have to be logged

and the specific reason is that nothing has been forwarded - so what should be displayed? Even if there have been some queries in this time frame, they must have all been answered from the cache.

An option might be to add a third forward destination which is the local cache. But then, "forward destination" doesn't seem to be the correct wording anymore. Also, this would still lead to empty slots if there are zero queries in that time - as in no other service is running on the Pi-hole and all clients are shut down, so there is really nobody asking anything.

[frankrpi3]

Hi,
don't know. During night there is only exact one query once an hour. This always works, so it's not that there are too les queries I think. Maybe you need a token?

[DL6ER]

The debug token will not help here since it does not contain any historic data of your log (only what you browsed during it saying that it is recording). I frankensteined together a synthetic log for tonight on my Pi-hole that is supposed to show the same behavior: lots of activity, but then one 10 minutes interval that only contains one forwarded query.

I don't see a hole in this situation. If, however, the single query has been blocked which is the same as if it would have been answered from the local cache - there is the hole you are describing.

Next, I removed an entire hour from my log (02:00 - 03:00), leaving only one query at 02:59:

And then removed even this one:

Can you send me the output of
http://pi.hole/admin/api.php?overTimeDataForwards&getForwardDestinationNames

maybe through a PastBin?

[frankrpi3]

Hi,
here you can see the logs when gap appeared:
http://fs5.directupload.net/images/170418/nfemptr6.png
There is only one query which is blocked.

I will try to send the output via PM...

[DL6ER]

Okay, I see that is the corresponding time frame, there are no queries that have been forwarded. However, the total amounts of queries is not equal to zero, so if I'd show any data in this gap, it would be wrong.

FTL v2.5 (not yet released) will add an additional forward destination called local which corresponds to all queries that have been answered from the cache. As such, this number will automatically include blocked queries, since they are also answered from the cache.

The graph does not necessarily look nicer with this modification, but at least there is no "hole" any more:

[technicalpyro]

this might be getting too complex but would it be a possibility to have the forward destination also check the status IE whether it was piholed or not and have that separated into two categories ?

as i understand the status returns there was one for successful vs blocked. seems like it might be do able to me

[DL6ER]

@technicalpyro Yes, that is in principle doable, but I don't really like it. It somewhat spoils the idea of presenting it as a forward destination if we separate between allowed and blocked cache answers...

[technicalpyro]

i guess the followup would then be since it is possible to separate them could they just be removed from the graph in the local portion ?

[DL6ER]

If I remove the blocked ones then we will again have the situation with holes as there have been queries in the time frame in question but no forward destination was responsible for serving them (not even local since we artificially removed that).

[technicalpyro]

ahhh yes yes sorry still waking up over here

[DL6ER]

No worries. I've just finished with work and go home now. I'll release the update of FTL either later today or tomorrow morning, when I'm sure I didn't break anything else.

[DL6ER]

FTL v2.5 released