Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database thread #100

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Refactor database thread #100

merged 1 commit into from
Jun 22, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 22, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

10


Refactor DB thread to run exclusively either saving queries into the DB or deleting old queries (i.e. every hour at minute 59 (e.g. 14:59) no queries will be saved to the DB, but instead, the remaining amount of data (14:58:01 - 14:59:59) will be saved at the next full minute (15:00)). In addition, we introduce mutex locks for the database handle, such that it is ensured that the database handle cannot be used more than once at the same time (that won't be needed, but an additional layer of "being sure" cannot hurt).

Fixes #97 #98

This template was created based on the work of udemy-dl.

…DB *or* deleting old queries (i.e. every hour at minute 59 no queries will be saved to the DB, but instead, two minutes of data will be saved at the full hour)
@DL6ER DL6ER added the Bugfix label Jun 22, 2017
@DL6ER DL6ER merged commit 4b818cc into development Jun 22, 2017
@DL6ER DL6ER deleted the fix/DB_GC branch June 22, 2017 21:27
@DL6ER DL6ER mentioned this pull request Jun 22, 2017
5 tasks
DL6ER pushed a commit that referenced this pull request Oct 14, 2019
Add endpoint for database generated summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant