Add E2E tests for pihole-FTL commands #1065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beanow
commented
Feb 17, 2021
| sleep 2 | ||
|
|
||
| # Now the daemon has stopped, run e2e tests. | ||
| test/libs/bats/bin/bats "test/e2e_test_suite.bats" |
There was a problem hiding this comment.
Looks like we need to explicitly track the return code, as the build passes while these tests fail.
1..5
ok 1 Running without arguments doesn't block and starts a daemon
ok 2 Running with 'no-daemon' blocks untill killed
not ok 3 Running with 'test' doesn't block and exits immediately
# (in test file test/e2e_test_suite.bats, line 47)
# `[[ ${lines[1]} == "PID: -" ]]' failed
# Jobs:
# PID: 2508
# Jobs:
# PID: -
not ok 4 Running with '-f test' blocks but exits immediately
# (in test file test/e2e_test_suite.bats, line 57)
# `[[ ${lines[1]} == "PID: -" ]]' failed
# Jobs:
# [1]+ Running timeout -k 5s -s TERM 3s /home/pihole/pihole-FTL -f test &> /dev/null &
# PID: 2533
# Jobs:
# PID: -
ok 5 Running with 'dnsmasq-test' doesn't block and exits immediately
CircleCI received exit code 0
There was a problem hiding this comment.
Yeah, look at what we do above for the other bats test. (RET variable later used in exit $RET).
This demonstrates issues where daemons are running unexpectedly. Signed-off-by: Beanow <497556+Beanow@users.noreply.github.com>
|
Some further tests have been done on branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates issues where daemons are running unexpectedly.
Can be used to validate #1064 is fixed.