Prevent race collisions when parsing FTL config file #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e overall memory consumption of FTL by a about 100 bytes, however, we do not need to allocate andfree when re-reading any runtime config lines (privacy mode, etc.). Signed-off-by: DL6ER <dl6er@dl6er.de>
…collisions Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
approved these changes
Oct 17, 2021
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-11-web-v5-8-and-core-v5-6-released/50566/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Fixes #1214. So far, memory was released whenever an operation was finished, however, we've seen a race collision where releasing the memory happened too early.
We address this in two ways:
As we need to read the config file every now and then (e.g., checking the privacy level) we can also just keep the memory instead of always getting "fresh" memory. This buys us some (very small) speed advantage at the costs of a few dozen bytes additional memory usage. This shouldn't be an issue in 2021.