Replace reference to hard-coded default GCinterval value #1313
Conversation
This hard-coded GCinterval value makes any change to the macro defining the GCinterval ineffective when the GC runs. For e.g., if I reduce the GC from once an hour to once every 3 minutes, the GC runs every 3 minutes, but the mintime is set to the start of the next hour, which wipes everything from the overTime data. I believe that this change is safe and can be merged and shipped to existing users because the GCinterval value is not configurable and users who don't build the PiHole version that they are running will not be affected by this change. Signed-off-by: Siddharth Kannan <mail@siddharthkannan.in>
|
The same comment as in #1312 applies here. Most of this was not really designed to run at any custom intervals and the lack of complains (so far) seems to have proven that basically nobody even tried it. In the ongoing Pi-hole v6.0 development, we're looking at using an in-memory SQLite3 database instead of relying heavily on our own datastructure to gain some more flexibility. This should also have taken care of these two bugs. |
Do you want to do this? If not, we can add an exception for your commits. |
|
Merged unsigned commit using admin privileges. |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?: 2
This hard-coded GCinterval value makes any change to the macro defining the GCinterval ineffective
when the GC runs.
For e.g., if I reduce the GC from once an hour to once every 3 minutes, the GC runs every 3 minutes,
but the mintime is set to the start of the next hour, which wipes everything from the overTime data.
I believe that this change is safe and can be merged and shipped to existing users because the
GCinterval value is not configurable and users who don't build the PiHole version that they are
running will not be affected by this change.
Signed-off-by: Siddharth Kannan mail@siddharthkannan.in
This template was created based on the work of
udemy-dl.