Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gray color in help output #1520

Merged
merged 1 commit into from Jan 9, 2023
Merged

Remove gray color in help output #1520

merged 1 commit into from Jan 9, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 8, 2023

What does this PR aim to accomplish?:

PR #1501 added a colorful output for pihole-FTL -h.
For some items it uses a gray color - but this is hardly readable when the terminal background is not pitch black.

Screenshot at 2023-01-08 22-18-44

This PR removed the gray and switches colors of those items to purple

Screenshot at 2023-01-08 22-25-59


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested review from a team and DL6ER January 8, 2023 21:29
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jan 8, 2023
@dschaper
Copy link
Member

dschaper commented Jan 8, 2023

I have no opinion on this PR directly but in general grey is fine to use, the visibility depends on your terminal color scheme.

@yubiuser
Copy link
Member Author

yubiuser commented Jan 8, 2023

Sure it depends on the terminal's color scheme. I did not modify this, this is the standard Linux Mint terminal with default settings.

@rdwebdesign
Copy link
Member

rdwebdesign commented Jan 8, 2023

Accessing via Putty (using default colors), the background is completely black, but the "normal white" is gray.
Only bold white text is really white.

The gray parameters (-q and [-h]) look too dark:

image

image

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on (a) that color schemas are subjective and user-configurable, however, also on (b) that it should look reasonable on default palettes. As both, Putty and Linux Mint can be considered widespread, this change seems to be a good one.

And @yubiuser made sure we do not use it again by deleting the definition of gray altogether 👍

@DL6ER DL6ER merged commit c4f38c7 into development Jan 9, 2023
@DL6ER DL6ER deleted the colors branch January 9, 2023 18:41
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-1-web-v5-18-1-and-core-v5-15-released/60495/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants