Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change log file location #169

Closed
wants to merge 1 commit into from
Closed

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 8, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Change log file location from /var/log/pihole-FTL.log to /var/log/pihole/FTL.log

Note that this is a breaking change in some sense as FTL will fail to start when the directory /var/log/pihole/ doesn't exist or isn't writable for user pihole

This template was created based on the work of udemy-dl.

…ole/FTL.log

Signed-off-by: DL6ER <dl6er@dl6er.de>
@dschaper
Copy link
Member

dschaper commented Dec 8, 2017

Hold for merge, will need to update the Core section to create the /var/log/pihole directory before we can set the FTL logs to that directory. Wait for @dschaper to approve before merge.

Copy link
Member

@dschaper dschaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please hold merge

@DL6ER DL6ER changed the title Change log file location [WIP] Change log file location Dec 8, 2017
@dschaper dschaper added the WIP label Dec 8, 2017
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still instances of pihole-FTL.log in the Makefile and readme (Travis CI config is ok though). Also, since we are making this change we should also move the other files like .pid and .port

@DL6ER
Copy link
Member Author

DL6ER commented Mar 2, 2018

Closing for revisiting later.

@DL6ER DL6ER closed this Mar 2, 2018
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/log-files-falsch-abgelegt-und-kein-flushing/8356/3

@DL6ER DL6ER deleted the new/logfilelocation branch November 9, 2018 20:17
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/empty-pihole-folder/23855/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants