Add extra logging around network issues (EDE: network error) #1930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR adds further error logging concerning (intermittent) network issues. Currently,
dnsmasq
doesn't provide any further details, making debugging quite hard. This PR was triggered by pi-hole/pi-hole#5608 which, eventually, turned out to be an external issue with other services on the same machine.Example: Simulating network outage by unplugging the Ethernet cable
UDP
Before:
Now:
TCP
Before:
Now:
Other possible errors could be
Connection reset by peer
orNo memory available
.These errors are also logged to the diagnosis system (rate-limited to not hammer the database):
These messages are de-duplicated based on the peer address (
192.168.2.1#53
in the screenshot).Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.