Don't create IPv6 cache entries when IPV6_ADDRESS is empty #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs.conf Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/ftl-v4-2-2-4-2-3-consumes-nearly-2x-more-memory-then-v4-11/17775/47 |
PromoFaux
previously requested changes
Mar 3, 2019
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com> Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
fix/IP_blocking_empty_address
branch
from
92b2aac
to
af7cf36
Compare
PromoFaux
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
Don't create IPv6 cache entries when
IPV6_ADDRESSis empty insetupVars.conf.Currently, we create empty (
::) IPv6 entries when users setBLOCKINGMODE=IPinpihole-FTL.confwhen theIPV6_ADDRESSvariable is empty (or unset) insetupVars.conf.This PR ensures that IPv6 entries are not created in
IPmode when we don't have a suitable address for them.This template was created based on the work of
udemy-dl.