Improvements for hostname resolving routines #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nged. Currently, we are storing their host names each time we reresolve the IP addresses, even if they have been found to be identical. This allows us to save memory in FTL processes that are running for a long time without being restarted. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
Please do not consider this PR a blocker. If 4.3 will be released before this PR has been tested, feel free to rebase this PR onto |
AzureMarker
reviewed
Apr 7, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
suggested changes
Apr 13, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
suggested changes
Apr 14, 2019
…l higher Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
Apr 14, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
Apr 14, 2019
…s is sometimes a bit cumbersome, however, it is necessary as we cannot completely lock the routines because this would prevent DNS resolution from being able to work Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
Apr 14, 2019
…he client/forward loops Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
This PR adds a few micro-optimizations and a bug fix for the host name resolving routines.
Improvement:
Bug fix:
strdup(). However, as a consecutivefree()was missing, some memory got lost.This template was created based on the work of
udemy-dl.