Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cmake #794

Merged
merged 7 commits into from May 26, 2020
Merged

Switch to cmake #794

merged 7 commits into from May 26, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 26, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR switches the Pi-hole FTL daemon build system to cmake.
The minimum required version of cmake is 2.8.12 (released October 2013) to ensure minimum added dependencies.

Users can either use cmake to integrate FTL into their development environments or simply use the provided script to generate an FTL binary.

./build.sh replaces make and automatically takes care of building in parallel when possible.

DL6ER added 7 commits May 26, 2020 20:35
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…uild.sh"

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.1 milestone May 26, 2020
@DL6ER DL6ER requested a review from dschaper May 26, 2020 21:00
@DL6ER DL6ER merged commit d17c9f8 into development May 26, 2020
@DL6ER DL6ER deleted the ci/cmake branch May 26, 2020 21:07
@DL6ER DL6ER mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants