New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues that occur if WebAdmin not installed #165
Fixed issues that occur if WebAdmin not installed #165
Conversation
Rebased on |
- Show the version as N/A (Not Available) instead of v-1 - Don't show out-of-date message in status message
Fixed Stickler errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't have needed to source that file if it was guaranteed that the file has been sourced already (ie. source it in the main script, not inside any function or Should I go ahead and do that? (i.e. add |
I think this is a good idea. |
@yubiuser Done! |
By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
Fix the errors mentioned in the Commit Message. The errors occur only when Web Interface not installed.
How does this PR accomplish the above?:
Checks if web interface installed. If not, sets version to 'N/A' instead of
v-1
What documentation changes (if any) are needed to support this PR?:
None