Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #94 #167

Merged
merged 2 commits into from Feb 19, 2022
Merged

Fix #94 #167

merged 2 commits into from Feb 19, 2022

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Aug 15, 2021

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.

What does this PR aim to accomplish?:
Fix #94

@subnut subnut mentioned this pull request Aug 16, 2021
Closed
@subnut subnut changed the title Fix https://github.com/pi-hole/PADD/issues/94 Fix #94 Aug 19, 2021
yubiuser
yubiuser approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on latest master and increase the version number by .0.1

@subnut
Copy link
Contributor Author

subnut commented Feb 19, 2022

@yubiuser Done.

@yubiuser yubiuser merged commit 13d2f02 into pi-hole:master Feb 19, 2022
@subnut subnut deleted the fix-#94 branch February 19, 2022 12:07
@KnownAim KnownAim mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PADD reports "Pi-hole is offline" after temporarily disabling Pi-hole
2 participants
@subnut @yubiuser