Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIXify padd.sh #212

Merged
merged 5 commits into from Apr 7, 2022
Merged

POSIXify padd.sh #212

merged 5 commits into from Apr 7, 2022

Conversation

yubiuser
Copy link
Member

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Make padd.sh posix compliant.

@yubiuser yubiuser changed the title POSIXify part I POSIXify padd.sh Mar 27, 2022
@yubiuser yubiuser marked this pull request as ready for review March 29, 2022 19:51
@yubiuser
Copy link
Member Author

Ready for review. Quiz: which is /bash and /sh ;-)

Bildschirmfoto zu 2022-03-29 21-43-14

@yubiuser yubiuser requested a review from a team March 29, 2022 19:53
@dschaper
Copy link
Member

That's so awesome! Thanks!

@dschaper dschaper self-assigned this Apr 2, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

yubiuser commented Apr 7, 2022

Rebased on latest development, merge conflicts resolved.

@yubiuser yubiuser merged commit a908753 into development Apr 7, 2022
@yubiuser yubiuser deleted the posix branch April 7, 2022 08:49
This was referenced May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants