Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
Fixes #224.
PR #212 removed the
declare -i core_count
becausedeclare
is not supported by POSIX. However, later we do an arithmetic+1
tocore_count
which will not be interpreted as addition but results in something like255+1
. This is not a visible issue, unlesscat /sys/devices/system/cpu/kernel_max
returns0
which leads to the issue seen in #224 (division by zero resulting ininf
byawk
)Use
$(( ))
syntax to do arithmetic expansion.By submitting this pull request, I confirm the following:
git rebase
)[x] I have read the above and my PR is ready for review. Check this box to confirm