Trim Docker Image #454
Merged
Trim Docker Image #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker fixes / updates for 4.2.1
Signed-off-by: Adam Hill <adam@diginc.us>
Release v4.2.2
Signed-off-by: Adam Hill <adam@diginc.us>
Fix typo
Clarify that people running --net=host should set ServerIP for Pi-hole to function correctly. I'll have to try to add some automation around this later to try to warn only the network host mode users if they miss it.
Update README.md
Signed-off-by: Adam Hill <adam@diginc.us>
Docker Pi-hole v4.3
Shallow clone pihole and webinterface repos to target branch. Only install curl and procps dependencies, as well as ca-certificates for curl'ing against https Cuts image size down by ~30MB (304MB -> 274MB) Signed-off-by: DistractionRectangle <48034372+DistractionRectangle@users.noreply.github.com>
|
Looks good to me, merged to dev to make a test image. |
This was referenced May 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shrink docker image by shallow cloning specific branches of pihole and webinterface repos.
Skip installing recommended packages for curl and procps; ca-certificates is added as an explicit
dependency as it's needed to curl against https urls (previously installed as a recommended package).
Motivation and Context
Reduces the size of the docker image by 10%, going from 304MB to 274MB
How Has This Been Tested?
Tested against automated tests.
Types of changes
Checklist: