Bcambl selinux notification #1028

merged 14 commits into from Dec 23, 2016


None yet

3 participants


By submitting this pull request, I confirm the following (please check boxes, eg [X])Failure to fill the template will close your PR:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

  • 10 (very familiar)

Expand on @bcambl 's branch to stop us from barging in on people's SELinux setups and enforcing our own rules

This template was created based on the work of udemy-dl.

bcambl and others added some commits Dec 23, 2016
@bcambl bcambl add warning if SELinux is Enforcing
@PromoFaux PromoFaux Merge branch 'selinux_notification' of https://github.com/bcambl/pi-hole
 into bcambl-selinux_notification
@PromoFaux PromoFaux untested convert user prompt to whiptail fdb64a5
@PromoFaux PromoFaux Make sure whiptail is installed... a8897be
@PromoFaux PromoFaux adjust size of whiptail dialog 662d450
@PromoFaux PromoFaux words words words c45c3a7
@PromoFaux PromoFaux maybe 00aff6a
@PromoFaux PromoFaux verbosity 15c674b
@PromoFaux PromoFaux newlines 4c131b8
@PromoFaux PromoFaux too many echos spoil the branch 754f335
@PromoFaux PromoFaux printf to echo. idgaf 9725985
@PromoFaux PromoFaux .
@Mcat12 Mcat12 Add newline
@Mcat12 Mcat12 Remove newline
Issue was already fixed

@bcambl You happy with this PR?

bcambl commented Dec 23, 2016

Looks good, Tests Good, and Approved.

@PromoFaux PromoFaux merged commit d12efcc into development Dec 23, 2016

4 checks passed

code-review/pullapprove Approved by bcambl, PromoFaux
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
licence/cla Contributor License Agreement is signed.
@Mcat12 Mcat12 deleted the bcambl-selinux_notification branch Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment