Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds DNS.WATCH to default dns servers #1253

Merged
merged 2 commits into from
Feb 18, 2017
Merged

Adds DNS.WATCH to default dns servers #1253

merged 2 commits into from
Feb 18, 2017

Conversation

nnt0
Copy link
Contributor

@nnt0 nnt0 commented Feb 18, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

3


Adds DNS.WATCH as a selectable dns server.

This template was created based on the work of udemy-dl.

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2017

CLA assistant check
All committers have signed the CLA.

@@ -444,6 +444,7 @@ setDNS() {
Level3 ""
Norton ""
Comodo ""
DNS.WATCH ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CamelCase please, just to match with the rest of the options. So DNSWatch, same on line 478. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited.

PromoFaux added a commit to pi-hole/web that referenced this pull request Feb 18, 2017
@PromoFaux
Copy link
Member

Approved

@dschaper
Copy link
Member

dschaper commented Feb 18, 2017

Approved

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants