Admin interface login not working after changing password with pihole -a -p

[srvaroa]

Versions

• Pi-hole version is v5.1.2 (Latest: v5.1.2)
• AdminLTE version is v5.1.1 (Latest: v5.1.1)
• FTL version is v5.2 (Latest: v5.2)

Platform

• OS and version: Linux 4.19.66-v7+ Adds DNS.WATCH to default dns servers pi-hole#1253 SMP Thu Aug 15 11:49:46 BST 2019 armv7l GNU/Linux
• Platform: Raspberry Pi 3

Expected behavior

After running pihole -a -p <new_password>, it should be possible to log in via the web interface with <new_password>

Actual behavior / bug

Login doesn't work.

Steps to reproduce

As noted above.

Debug Token

• URL:

https://tricorder.pi-hole.net/1qy00pb1zh

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

• Removing the password does work (pihole -a -p, then entering blank password).
• After setting a password, I do see WEBPASSWORD updated at /etc/pihole/setupVars.conf
• I've tried setting the password and rebooting before trying to log in without success

[PromoFaux]

I wonder if it is something to do with a combination of characters that you are using. Hard to tell, and the password is not stored in the debug log.

Could you try something simple like pihole -a -p test1234 and tell me if it works?

[srvaroa]

Hi, I've tried with simple ones (e.g. hello), but no luck.

[PromoFaux]

What is the output of the following, please?

pihole -a -p hello
cat /etc/pihole/setupVars.conf | grep WEBPASSWORD

[srvaroa]

WEBPASSWORD=d7914fe546b684688bb95f4f888a92dfc680603a75f23eb823658031fff766d9

[PromoFaux]

OK, so that is the correct value. What do you see when you try to log in on the web interface? I have just tried it myself, and it works...

If it does not work for you, please include whether or not you see any console errors in the web browser's developer tools (usually F12, depending on the browser you are using)

Out of interest, what browser are you using?

[srvaroa]

I'm on Firefox 78.4.0esr. There are some errors in the console that might be related. I have just tested with private mode and it does work well, and those errors are not shown. Interestingly, they don't appear in private mode.

In any case it doesn't really look like a bug on the UI side so feel free to close the issue.

Thanks a lot for your help!

[PromoFaux]

Ah, this may already be dealt with in development, but I am not sure. I'll transfer this issue to the web repo until I've had a chance to confirm.

[PromoFaux]

I've tried latest firefox on both master and development, and while they both show the warning, it still allows the login.

Gif from dev below:

I also tried 78.4.0esr, and am unable to reproduce. As you say @srvaroa, it worked in private browsing mode, so the cookie warning might be a red herring at this stage... maybe you have some extension that is preventing login? Does it allow you to log in if you don't check the "Remember Me" button?

@XhmikosR - might need you to jog my memory! We did something with the cookie types before the last release, no? Should it be something other?

[XhmikosR]

The only related change I can think of is #1350. #1447 and the SameSite attribute is missing which is why I made https://github.com/pi-hole/AdminLTE/compare/cookies but I never got to finish it to support old PHP versions.

I'd manually clear the cookie.

[PromoFaux]

I could have sworn we'd already added in the SameSite=Lax, stuff, apparently not! It's been a long year... I'll attempt to answer some questions over on #1447

[github-actions]

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.