Make "pihole -d -a" automatically upload the debug log #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… token + some cosmetics for displaying on the web interface
|
You mean |
DL6ER
changed the title
|
Whoops, Yes. Not |
|
Changed title to "Make Dan finish the code already..." |
|
Approved |
AzureMarker
reviewed
Feb 25, 2017
| @@ -336,7 +342,11 @@ countdown() { | |||
| printf "::: Logging will automatically teminate in ${TIMEOUT} seconds\n" | |||
| while [ $tuvix -ge 1 ] | |||
| do | |||
| printf ":::\t${tuvix} seconds left. \r" | |||
| if ! ${automated} ; then | |||
| printf ":::\t${tuvix} seconds left. \r" | |||
There was a problem hiding this comment.
Has no newline, causing output like this (captured via web debug):
::: 60 seconds left. ::: 55 seconds left. ::: 50 seconds left.
There was a problem hiding this comment.
There shouldn't be a new line, it has a carriage return to overwrite the counter on a terminal display.
|
Do not merge until the back end code is there, or we're going to have a bad time. |
|
See #1281 for back and updates. |
dschaper
approved these changes
Feb 27, 2017
|
Does this conflict with #1281 ? |
|
Implemented by #1281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?: 10
Needed for pi-hole/web#399
Can be merged w/o merging pi-hole/web#399
This template was created based on the work of
udemy-dl.