Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back end changes for Web based debug calls. #1281

Merged
merged 7 commits into from Feb 27, 2017
Merged

Back end changes for Web based debug calls. #1281

merged 7 commits into from Feb 27, 2017

Conversation

dschaper
Copy link
Member

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10

pihole -d -a now will operate autonomously and upload the logs after set timeout. Set for web based debug calls.

This template was created based on the work of udemy-dl.

Dan Schaper and others added 2 commits February 26, 2017 15:36
Modify pihole for -d -a arguments.
ba5bbf3
@dschaper
Debug auto mode engaged
9b060aa 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper dschaper added the PR: Code Review Required Open Pull Request, needs code reviewd label Feb 27, 2017
@dschaper dschaper self-assigned this Feb 27, 2017
@dschaper dschaper requested a review from DL6ER February 27, 2017 02:25
@dschaper dschaper mentioned this pull request Feb 27, 2017
Closed
5 tasks
@jacobsalmela
Copy link
Contributor

jacobsalmela commented Feb 27, 2017 •
edited by dschaper

Approved

Approved with PullApprove

@dschaper
Notify user that log is being uploaded.
7244d44 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Vebiage and highligh the token, also :::
6c130b7 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Help text clarification and addition of the automated debuggin flag.
38961fb 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Carriage return or newline based webcalls.
83b0600 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Fix for calling -w without -a.
17b0db6 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Copy link
Member Author

That should do it for the commits, unless any bugs are noted in the testing.

@DL6ER
Copy link
Member

DL6ER commented Feb 27, 2017 •
edited by dschaper

Approved, ready for merge?

Approved with PullApprove

@dschaper dschaper merged commit f6fc6a5 into development Feb 27, 2017
@dschaper dschaper deleted the tweak/web_debug branch February 27, 2017 20:21
@dschaper dschaper removed the PR: Code Review Required Open Pull Request, needs code reviewd label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER Awaiting requested review from DL6ER

Assignees

@dschaper dschaper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dschaper @jacobsalmela @DL6ER