Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only provide service output when exit status != 0 #1624

Closed
wants to merge 4 commits into from
Closed

Only provide service output when exit status != 0 #1624

wants to merge 4 commits into from

Conversation

WaLLy3K
Copy link
Contributor

@WaLLy3K WaLLy3K commented Jul 20, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9

Resolves the issue that #1610 aimed to fix.

@WaLLy3K WaLLy3K added this to the v3.2 milestone Jul 20, 2017
WaLLy3K
WaLLy3K commented Jul 21, 2017
View reviewed changes
Copy link
Contributor Author

@WaLLy3K WaLLy3K left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my setup, using "force-reload" instead of "restart" is 22 seconds faster and will enforce whitelists, blacklists and even "-a interface" changes instantly.

@WaLLy3K WaLLy3K added the WIP Work in progress. label Jul 22, 2017
@WaLLy3K
Copy link
Contributor Author

WaLLy3K commented Jul 22, 2017

The force-reload fix needs to be re-implemented and has become a requirement for another upcoming PR, so I'm closing this for now.

@WaLLy3K WaLLy3K closed this Jul 22, 2017
@WaLLy3K WaLLy3K deleted the fix/service-handling branch July 22, 2017 12:38
@WaLLy3K WaLLy3K removed the WIP Work in progress. label Jul 22, 2017
WaLLy3K added a commit that referenced this pull request Jul 24, 2017
@WaLLy3K
Add dnsmasq "force-reload" option
a2825be 
* Made use of $PI_HOLE_SCRIPT_DIR
* Fix #1610 & #1624
* Add "$2" to restartDNS options

Signed-off-by: WaLLy3K <wally3k@pi-hole.net>
@WaLLy3K WaLLy3K mentioned this pull request Jul 24, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.
1 participant
@WaLLy3K