Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement for Chronometer #1880

Merged
merged 1 commit into from
Dec 30, 2017
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 30, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix a potential issue as discussed here: https://discourse.pi-hole.net/t/bad-file-descriptor-output-when-using-chronometer/6234

How does this PR accomplish the above?:

Exchange hard-coded domain localhost by hard-coded address 127.0.0.1

@DL6ER DL6ER added this to the v3.3 milestone Dec 30, 2017
@DL6ER DL6ER requested a review from WaLLy3K December 30, 2017 16:48
@DL6ER DL6ER merged commit 5254fc6 into development Dec 30, 2017
@DL6ER DL6ER deleted the fix/chronometer_localhost branch December 30, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants