Fix: add psmisc as dependency #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Apr 19, 2018
automated install/basic-install.sh
Outdated
| @@ -163,7 +163,13 @@ if command -v apt-get &> /dev/null; then | |||
| # These programs are stored in an array so they can be looped through later | |||
| INSTALLER_DEPS=(apt-utils dialog debconf dhcpcd5 git ${iproute_pkg} whiptail) | |||
| # Pi-hole itself has several dependencies that also need to be installed | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Couldn't parse this here string.
The mentioned parser error was in this simple command.
Fix any mentioned problems and try again.
Debian 9.4 does not install `psmisc` by default and the following error will happen during installation: ``` [✗] /usr/local/bin/pihole: line 353: killall: command not found /usr/local/bin/pihole: line 364: killall: command not found ``` This patch adds `psmisc` (that contains `killall`) as dependency Signed-off-by: Michele Bologna <michele.bologna@gmail.com>
|
Thanks for the contribution. |
dschaper
added
PR: Code Review Required
bcambl
approved these changes
Apr 20, 2018
dschaper
added
PR: Approved
dschaper
removed
PR: Approved
|
@mbologna please contact me directly for a special thank you for contributing to our project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]
git rebase)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
Debian 9.4 does not install
psmiscby default and the following error will happen during installation:How does this PR accomplish the above?:
This patch adds
psmisc(that containskillall) as dependency