Remove deprecated Disconnect lists from "defaults" #3451
Conversation
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
PromoFaux
force-pushed
the
its-getting-awful-quiet-in-here
branch
from
efe96d5
to
4f7bb7b
Compare
| @@ -1240,8 +1238,6 @@ appendToListsFile() { | |||
| case $1 in | |||
| StevenBlack ) echo "https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts" >> "${adlistFile}";; | |||
| MalwareDom ) echo "https://mirror1.malwaredomains.com/files/justdomains" >> "${adlistFile}";; | |||
| DisconTrack ) echo "https://s3.amazonaws.com/lists.disconnect.me/simple_tracking.txt" >> "${adlistFile}";; | |||
There was a problem hiding this comment.
Are both lists deprecated? Just wondering :)
There was a problem hiding this comment.
Per the response from disconnect.me to the op of #3450
The list you referenced was used in our legacy products. It is not maintained, has not been updated, and is not actively distributed us. Airbrake is not included on our main tracker list (linked below) which is used by partners such as Firefox.
https://github.com/disconnectme/disconnect-tracking-protection/blob/master/services.json
I'm making the reasonable assumption that both lists are no longer updated/distributed. Besides which, when removed only 337 domains are "lost" from an install that has all lists selected.
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/initial-deployment-docker-errors/34811/15 |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
See #3450 for details
Removing these lists only removes 337 unique domains from a fresh install with all the lists selected. No brainer really, especially as they're deprecated!
With:
Without: