-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect.me list is deprecated #3450
Comments
Thanks for the report, As they're deprecated we may as well remove them from the "default" (read: optional) list selection. There are only 337 unique domains not found on the other two lists, and even then, as the list is no longer even updated, it's likely at least some of them are no longer valid. |
Thank you @PromoFaux 👍 🎉 |
This issue has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/initial-deployment-docker-errors/34811/15 |
Can be closed as v5.1 has released. |
In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}
How familiar are you with the the source code relevant to this issue?:
(1) I am not personally familiar with the source code related to this behavior other than this appears to be the line where the deprecated file is included:
pi-hole/automated install/basic-install.sh
Line 1233 in 4d25f69
Expected behaviour:
Deprecated lists are not included by default
Actual behaviour:
Deprecated list is included by default
Steps to reproduce:
Run basic install and observe deprecated tracker list is used (
disconnect.me/simple-tracking.txt
).Debug token provided by uploading
pihole -d
log:Not applicable
Troubleshooting undertaken, and/or other relevant information:
Hi there,
Full disclosure: I work at Airbrake (https://airbrake.io/). We noticed that this project is using a tracker list file (https://s3.amazonaws.com/lists.disconnect.me/simple_tracking.txt) that lists Airbrake as an ad tracker. Airbrake is an application monitoring tool (error monitoring, deploy tracking, performance monitoring). Error monitoring is an essential tool for app developers to fix bugs that pop up in their code. It doesn't track users or take screenshots of users' actions.
We contacted Disconnect.me (support@disconnect.me) and they shared this with us:
The text was updated successfully, but these errors were encountered: