Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install RFC6761 config file #4282

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Install RFC6761 config file #4282

merged 3 commits into from
Sep 11, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 15, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Implement what a caching DNS server should do following RFC 6761

How does this PR accomplish the above?:

Add additional config similar to what OpenWRT does as well

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added Nice to have Feature Request: Discourse Implements a Feature Request from Discourse labels Aug 15, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/please-advise-additional-dnsmasq-entries/48897/7

@@ -1284,7 +1286,7 @@ version_check_dnsmasq() {
fi
# Copy the new Pi-hole DNS config file into the dnsmasq.d directory
install -D -m 644 -T "${dnsmasq_pihole_01_snippet}" "${dnsmasq_pihole_01_location}"
printf "%b %b Copying 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf\\n" "${OVER}" "${TICK}"
printf "%b %b Copied 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf\\n" "${OVER}" "${TICK}"
Copy link
Member

@PromoFaux PromoFaux Aug 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only on the slowest of all the slowest machines in the world will one ever see the word Copying in this case. But sure makes more sense grammatically.

advanced/06-rfc6761.conf Outdated Show resolved Hide resolved
@DL6ER DL6ER marked this pull request as draft August 15, 2021 16:27
@DL6ER DL6ER removed the request for review from dschaper August 15, 2021 16:27
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER marked this pull request as ready for review August 15, 2021 16:37
Signed-off-by: DL6ER <dl6er@dl6er.de>
@PromoFaux PromoFaux merged commit 89e1879 into release/v5.4 Sep 11, 2021
@PromoFaux PromoFaux deleted the new/RFC6761 branch September 11, 2021 19:44
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-10-1-web-v5-7-and-core-v5-5-released/50009/4

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftl-v5-12-1-not-honoring-interface-and-bind-interfaces/52058/15

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/test-tld-not-resolving/59573/4

@HVR88
Copy link

HVR88 commented May 16, 2024

Great idea, now look at the 100's of opening posts and 1000's of replies trying to figure out why .local addresses don't work with PiHole.

@yubiuser
Copy link
Member

Did you look at the actual PR at all? It states clear with the new conf file

We do not include the ".local" rule ourselves, see #4282 (comment)

@HVR88
Copy link

HVR88 commented May 16, 2024

Yes. Have you read any of the threads? Have you tried these TLDs in the local DNS records in pihole?

@yubiuser
Copy link
Member

.local is forwarded upstreams.

May 16 20:22:40 dnsmasq[283]: forwarded test1.local to 172.19.0.2
May 16 20:22:40 dnsmasq[283]: reply test1.local is NXDOMAIN

these TLDs in the local DNS records in pihole?

I don't know what local DNS records have to do with this PR about not forwarding certain domains, but they're answered as they should be by Pi-hole itself.

May 16 20:28:22 dnsmasq[264280]: query[A] test2.local from 10.0.1.202
May 16 20:28:22 dnsmasq[264280]: /etc/pihole/custom.list test2.local is 123.123.123.123

May 16 20:30:47 dnsmasq[264396]: query[A] test.test from 10.0.1.202
May 16 20:30:47 dnsmasq[264396]: /etc/pihole/custom.list test.test is 7.7.7.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request: Discourse Implements a Feature Request from Discourse Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants