-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install RFC6761 config file #4282
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/please-advise-additional-dnsmasq-entries/48897/7 |
automated install/basic-install.sh
Outdated
@@ -1284,7 +1286,7 @@ version_check_dnsmasq() { | |||
fi | |||
# Copy the new Pi-hole DNS config file into the dnsmasq.d directory | |||
install -D -m 644 -T "${dnsmasq_pihole_01_snippet}" "${dnsmasq_pihole_01_location}" | |||
printf "%b %b Copying 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf\\n" "${OVER}" "${TICK}" | |||
printf "%b %b Copied 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf\\n" "${OVER}" "${TICK}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only on the slowest of all the slowest machines in the world will one ever see the word Copying
in this case. But sure makes more sense grammatically.
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-10-1-web-v5-7-and-core-v5-5-released/50009/4 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/ftl-v5-12-1-not-honoring-interface-and-bind-interfaces/52058/15 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/test-tld-not-resolving/59573/4 |
Great idea, now look at the 100's of opening posts and 1000's of replies trying to figure out why .local addresses don't work with PiHole. |
Did you look at the actual PR at all? It states clear with the new conf file
|
Yes. Have you read any of the threads? Have you tried these TLDs in the local DNS records in pihole? |
I don't know what local DNS records have to do with this PR about not forwarding certain domains, but they're answered as they should be by Pi-hole itself.
|
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
Implement what a caching DNS server should do following RFC 6761
How does this PR accomplish the above?:
Add additional config similar to what OpenWRT does as well
What documentation changes (if any) are needed to support this PR?:
None