Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local-ttl from set of default dnsmasq options #4339

Merged
merged 1 commit into from Sep 25, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 24, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Give users the ability to set local-ttl themselves if they want to.

How does this PR accomplish the above?:

We used local-ttl to control the TTL of blocked queries. We didn't want it to be too high to not render whitelisting ineffective. As pi-hole/FTL#1173 decouples the TTL of blocked queries from other local names, the reason to set this config option vanished.

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team September 24, 2021 09:36
@DL6ER DL6ER merged commit 0576810 into development Sep 25, 2021
@DL6ER DL6ER deleted the tweak/local_ttl branch September 25, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants