Handle TTL for blocked queries seperately #1173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
So far, we used
local-ttl=2
hard-coded in dnsmasq's config because this ensured clients won't cache blocked queries for longer times, possibly rendering whitelisting ineffective.This PR implements a new TTL for blocked queries only. This allows users to set
local-ttl
to any value they prefer without this being overwritten in01-pihole.conf
after each update. This seems useful in context of locally used hostnames that are known to stay constant over long times (e.g., printers, etc.).The new value defaults to
2
seconds (no change in behavior) and can be controlled using the new FTL config optionBLOCK_TTL=2