Remove read permission for others on sensible log files #4760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the read permission for
others
for certain files:/var/log/pihole/pihole.log
(dnsmasq
log file)Both files can contain highly sensible data and should not be readable by everyone.
P.S.
pihole -t
needs sudo powers now, tailing via the web interface still works.Make change visible in the release notes
By submitting this pull request, I confirm the following:
git rebase
)