-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more than one default gateway in debug script #4934
Conversation
Signed-off-by: Christian König <ckoenig@posteo.de>
Do you think we really need to ping6 addresses? I like the changes for IPv4 but I'm wondering if there is any use to ping IPv6 addresses since they could be LL that don't tell us much and trying to decide what type of IPv6 addresses they are is way to deep in the weeds. |
Users might be on IPv6-only networks. We could check if the device has a GUA address and ping the respective gateway |
a94a7a7
to
22ebf21
Compare
That's the kind of complexity that I'd like to avoid. I can see the rare case that a network may be IPv6 only, I don't know how useful the ping test is in that case (and really in any case) since you need a gateway of some type in order to get the debug log on to |
What does this PR aim to accomplish?:
Fixes #4933
If more than one default gateway is associated with an interface (usually IPv6) we saved all of them as a single string in
gateway
and then try to ping this during the debug run. Ping this "address" failed.Before:
After:
Create an array containing all the default gateways for one interface and only try to ping the first one.
By submitting this pull request, I confirm the following:
git rebase
)