Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup if startup failed #5052

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Cleanup if startup failed #5052

merged 2 commits into from
Jan 22, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 8, 2022

What does this PR aim to accomplish?:

Cleanup files if pihole-FTL did not start properly after getting invoked by pihole-FTL.service.

With #4857 we added the exit code, however do not use ist so far. Now we do.

This is a re-implementation of #4887 after #4924 has been merged

How does this PR accomplish the above?:

Run the pihole-FTL-poststop.sh if pihole-FTL started with a non-zero exit code or we trap INT HUP TERM ABRT


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser mentioned this pull request Dec 8, 2022
1 task
@yubiuser yubiuser requested a review from a team December 11, 2022 19:35
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Dec 22, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from MichaIng January 3, 2023 20:20
@yubiuser yubiuser requested review from a team and MichaIng and removed request for MichaIng January 20, 2023 16:04
@MichaIng
Copy link
Contributor

I cannot do reviews on this repo btw, but looks good 👍.

@yubiuser yubiuser merged commit d0affcb into development Jan 22, 2023
@yubiuser yubiuser deleted the cleanup2 branch January 22, 2023 08:30
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants