Create versions file before sourcing it #5097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
We use
/etc/pihole/versions
to store version, branch and hash information of the Pi-hole components. This file is populated byupdatechecker.sh
. Other scripts source this file. Among them, ispihole
itself.pi-hole/pihole
Lines 26 to 27 in fe598a0
During installation, we call
updatecheck
as one of the last functions.pi-hole/automated install/basic-install.sh
Lines 2720 to 2724 in fe598a0
Right before, we run gravity, which itself uses a function provided by
pihole
, e.g.pi-hole/gravity.sh
Line 994 in fe598a0
This is a issue on fresh installation, as
/etc/pihole/versions
won't exist yet, leading to errorsHow does this PR accomplish the above?:
Simply swap
gravity
run andupdatechecker
during the installation.By submitting this pull request, I confirm the following:
git rebase
)