Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only source versions file if the file exits #5157

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Feb 2, 2023

What does this PR aim to accomplish?:

Fixes warnings during first time installation that /etc/pihole/versions does not exists. I already fixed this with #5097 but accidentally reverted that change by #5137.

This PR should fix both issues: run gravity before updatechecker and suppress warning during first time installations.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team February 2, 2023 11:01
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Feb 2, 2023
@yubiuser yubiuser added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Feb 9, 2023
@PromoFaux PromoFaux merged commit 0ac89ac into development Feb 9, 2023
@PromoFaux PromoFaux deleted the source_only_if_available branch February 9, 2023 18:34
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-21-web-v5-18-4-and-core-v5-15-4-released/61096/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants