-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pihole-admin.conf to debug log #5144
Conversation
Signed-off-by: Christian König <ckoenig@posteo.de>
I like the idea, but I have questions:
|
Do, I don't think so. Adding a logic in the very clear and well organized structure of the debug script for a particular case seems a bit overkill. We won't be able to re-use the function anywhere else. We know which directory exists on which distro, most users won't even notice one skipped dir.
Isn't it the other way round |
Signed-off-by: Christian König <ckoenig@posteo.de>
The changes made to |
Signed-off-by: Christian König <ckoenig@posteo.de>
Added the output of |
Signed-off-by: Christian König <ckoenig@posteo.de>
Last commit will print all files (not their content) of the lighttpd config directories. |
Sample output
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-21-web-v5-18-4-and-core-v5-15-4-released/61096/1 |
What does this PR aim to accomplish?:
Adds the "new" lighttpd
pihole-admin.conf
to the debug output.Additionally, fixed a bug where we try to
list_files_in_dir
even ifdir_check
says there is no directory (we never checked the output ofdir_check()
.By submitting this pull request, I confirm the following:
git rebase
)