Ignore commented lines when reading PRIVACYLEVEL from config file #5177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
During updates, we extract
PRIVACYLEVEL
from/etc/pihole/pihole-FTL.conf
and later set it againpi-hole/automated install/basic-install.sh
Lines 2613 to 2619 in d86b325
pi-hole/automated install/basic-install.sh
Line 1852 in d86b325
However, if
/etc/pihole/pihole-FTL.conf
contains a commented line containingPRIVACYLEVEL
, setting it during update will fail because it did not ignore the commented line.This was reported here: #5174
How does this PR accomplish the above?:
Adding a
sed
to remove all commented lines from/etc/pihole/pihole-FTL.conf
before extractingPRIVACYLEVEL
By submitting this pull request, I confirm the following:
git rebase
)