Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting 'privacylevel' #5224

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix getting 'privacylevel' #5224

merged 1 commit into from
Mar 22, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Better re-implementation of #5177.
Using the sed | grep | awk directly within the installation script should prevent update failures while utils.sh is still not updated.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team March 22, 2023 22:02
@dschaper dschaper requested a review from PromoFaux March 22, 2023 22:08
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pi@raspberrypi:~ $ sed -e '/^[[:blank:]]*#/d' /etc/pihole/pihole-FTL.conf | grep "PRIVACYLEVEL" | awk -F "=" 'NR==1{printf$2}'
0

@PromoFaux PromoFaux merged commit 1dc3312 into development Mar 22, 2023
@PromoFaux PromoFaux deleted the fix/privacy branch March 22, 2023 22:11
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-22-web-v5-19-and-core-v5-16-1-released/61999/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants