Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert domain to lowercase in pihole -q #5200

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Convert domain to lowercase in pihole -q #5200

merged 2 commits into from
Mar 8, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Mar 6, 2023

What does this PR aim to accomplish?:

Converts the domain passed to pihole -q to lowercase before running the actual search.

Fixes #5199

How does this PR accomplish the above?:

tr '[:upper:]' '[:lower:]'


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team March 6, 2023 20:19
@yubiuser yubiuser linked an issue Mar 6, 2023 that may be closed by this pull request
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Convert input to lowercase in pihole -q Convert domain to lowercase in pihole -q Mar 6, 2023
advanced/Scripts/query.sh Outdated Show resolved Hide resolved
Signed-off-by: Christian König <ckoenig@posteo.de>
@dschaper dschaper self-requested a review March 7, 2023 19:42
@dschaper dschaper merged commit 04b909c into development Mar 8, 2023
@dschaper dschaper deleted the fix/query branch March 8, 2023 01:49
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-22-web-v5-19-and-core-v5-16-1-released/61999/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pihole -q is case sensitive, pihole-FTL regex-test isn't
6 participants