Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake user agent when downloading adlists #5366

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 21, 2023

What does this PR aim to accomplish?:

After internal discussion, having a fixed, outdated user agent might do more harm then having none.

This PR implements a random selection from 5 (current) user agent strings when downloading the adlists

After internal discussion, having a fixed, outdated user agent might do more harm then defaulting to curl's default.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@dschaper
Copy link
Member

There has been some discussion about the need of a custom/modified useragent string.

I haven't seen anywhere that rejects when the default useragent string provided, at least not in the last few years. Originally there was some servers that did, possibly even GitHub itself. But I don't think that has been the case for quite a while now.

@yubiuser yubiuser changed the title Remove user agent when downloading adlists Choose user agent randomly when downloading adlists Aug 27, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Choose user agent randomly when downloading adlists Remove fake user agent when downloading adlists Sep 3, 2023
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Sep 3, 2023
@yubiuser
Copy link
Member Author

yubiuser commented Sep 3, 2023

Ready for review

@yubiuser yubiuser merged commit 4955c52 into development Sep 10, 2023
18 checks passed
@yubiuser yubiuser deleted the no_agent_dev branch September 10, 2023 19:20
@PromoFaux PromoFaux mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants