Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake user agent when downloading adlist #5367

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

yubiuser
Copy link
Member

Same as #5366 but for v6

@yubiuser yubiuser requested a review from a team August 21, 2023 19:32
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Remove user agent when downloading adlists Choose user agent randomly when downloading adlists Aug 27, 2023
gravity.sh Outdated Show resolved Hide resolved
gravity.sh Outdated Show resolved Hide resolved
Copy link

@prichert prichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements

@yubiuser
Copy link
Member Author

yubiuser commented Sep 3, 2023

@prichert Thanks for your review. After some internal discussion, we decided to remove the fake user agent and to go with the default curl provided. I'm going to force push away the latter two commits so your remarks don't apply anymore.

@yubiuser yubiuser changed the title Choose user agent randomly when downloading adlists Remove fake user agent when downloading adlist Sep 3, 2023
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Sep 3, 2023
@yubiuser
Copy link
Member Author

yubiuser commented Sep 3, 2023

Ready for review

@yubiuser yubiuser merged commit 20a3593 into development-v6 Sep 10, 2023
15 checks passed
@yubiuser yubiuser deleted the no_agend_devv6 branch September 10, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants