Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 204 return code for deleted sessions #5541

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Use 204 return code for deleted sessions #5541

merged 1 commit into from
Jan 27, 2024

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 7, 2024

Changes the return code for a successful deleted session after the changes made in pi-hole/FTL#1836


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Member Author

yubiuser commented Jan 7, 2024

Needs to be rebased after #5542 has been merged

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit cc8f9fe into development-v6 Jan 27, 2024
15 checks passed
@yubiuser yubiuser deleted the 204 branch January 27, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants