-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests in development-v6 branch #5542
Conversation
…wnloaded for the tests. We need to change this to `develoment` once v6 is released Signed-off-by: Adam Warner <me@adamwarner.co.uk>
4620c11
to
3d4f84e
Compare
3d4f84e
to
704e546
Compare
Should we test for all architectures we have FTL builds for? |
704e546
to
058a27f
Compare
We probably should. Just FP'd over the last commit, in which I have reduced some code duplication for each arch's test. Easier to maintain, and less places to remember to change Edit: one more FP to change |
040e568
to
de53f02
Compare
Use parametrize to run the same test with different parameters for each arch we need to test. Also include detection of unusupported in this test. Create FTL_BRANCH constant to be used in functions (less places to remember to change it) Signed-off-by: Adam Warner <me@adamwarner.co.uk>
de53f02
to
df9c60e
Compare
Wait, we don't check for i386. And do we really need a check for both |
i386 not as straightforward to test (see the code in the basic install that handles it) I did look at adding a mock for the dpkg command earlier (uname is still x86_64) , but it didn't work. I can try again if it is important. Really, aside from adding risc, I just used the same arch's that were already in the test. Can only assume i386 was left out on purpose before, too. |
Maybe it's not important :) |
288658b
to
df9c60e
Compare
I have FP'd away the previous commit that added the i386 tests. On closer inspection, the only OS we support that even has a 386 flavour is debian, and even then - I doubt all that many people are using it. It is likely why the test was left out initially. Adding it to the new tests causes the Fedora/Centos tests to fail - we could code around that with some exceptions, but it's a lot of completixty for what probably is not a lot of gain |
What does this PR aim to accomplish?:
A change was introduced way back in June that presumably broke the tests. This got worked around by uploading the v6 binaries to the latest v5 release. No bueno.
The correct fix should have been to ensure that the
devlopment-v6
branch of FTL is selected before trying to download it in tests (as we do with other tests).We must ensure these tests get changed when
development-v6
becomesdevelopment
By submitting this pull request, I confirm the following:
git rebase
)