Add test to avoid "Undefined Variable" warnings

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
pi-hole · Aug 28, 2022 · ae74023 · ae74023
1 parent ce8045b
commit ae74023
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/scripts/pi-hole/php/update_checker.php b/scripts/pi-hole/php/update_checker.php
@@ -65,14 +65,19 @@ function checkUpdate($currentVersion, $latestVersion)
     $core_latest = $versions['GITHUB_CORE_VERSION'];
     $web_latest = $versions['GITHUB_WEB_VERSION'];
     $FTL_latest = $versions['GITHUB_FTL_VERSION'];
-    $docker_latest = $versions['GITHUB_DOCKER_VERSION'];
+    if (isset($versions['GITHUB_DOCKER_VERSION'])) {
+        $docker_latest = $versions['GITHUB_DOCKER_VERSION'];
+    } else {
+        $docker_latest = '';
+    }
 
     // Version comparison
     if (!$docker_current) {
         // Not a docker container
         $core_update = checkUpdate($core_current, $core_latest);
         $web_update = checkUpdate($web_current, $web_latest);
         $FTL_update = checkUpdate($FTL_current, $FTL_latest);
+        $docker_update = false;
     } elseif ($docker_current == 'nightly' || $docker_current == 'dev') {
         // Special container - no update messages
         $docker_update = false;