Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit cookies #1447

Closed
XhmikosR opened this issue Jun 6, 2020 · 1 comment
Closed

Revisit cookies #1447

XhmikosR opened this issue Jun 6, 2020 · 1 comment
Labels
Security Submitter Attention Required

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Jun 6, 2020 •
edited
Loading

After #1256 is sorted:

  1. We should probably revisit the cookies path; we are not setting it and I'm not sure if it's correct.
  2. There's still a PHPSESSID cookie which I'm unsure how to tackle
  3. We should eventually look into adding the Secure option if one is running the admin interface on https
  4. Ideally we shouldn't touch the cookie in JS and thus add the httponly flag too

Split from #1256 (comment)
@XhmikosR XhmikosR mentioned this issue Oct 25, 2020
Closed
@PromoFaux PromoFaux mentioned this issue Sep 11, 2021
Merged
8 tasks
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Security Submitter Attention Required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XhmikosR