Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit log button #1518

Merged
merged 1 commit into from Jul 30, 2020
Merged

Fix audit log button #1518

merged 1 commit into from Jul 30, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 20, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix audit log feature #1470 pi-hole/pi-hole#3552

How does this PR accomplish the above?:

Add missing action to add domains to the audit log table.

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Jul 20, 2020
@DL6ER DL6ER requested a review from PromoFaux July 20, 2020 20:07
@DL6ER DL6ER linked an issue Jul 20, 2020 that may be closed by this pull request
3 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/audit-log-dns-ftl-aussetzer-nach-update-auf-5-1-1/35623/26

@DL6ER DL6ER requested a review from XhmikosR July 20, 2020 20:32
@DL6ER DL6ER added this to the v5.1.1 milestone Jul 20, 2020
@PromoFaux PromoFaux mentioned this pull request Jul 24, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/clicking-audit-button-triggers-lighttpd-error/36305/2

@DL6ER DL6ER requested a review from a team July 30, 2020 07:05
@DL6ER DL6ER merged commit 0865123 into release/v5.1.1 Jul 30, 2020
@DL6ER DL6ER deleted the fix/audit_log branch July 30, 2020 19:50
@DL6ER DL6ER mentioned this pull request Jul 30, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-2-released/36964/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log buttons adds to whitelist on v5.1.1 and produced lighttpd errors
3 participants