Query Log 'whitelist' button not adding to whitelist

[ray73864]

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:

1

---

Expected behavior:

When using the web interface in the Query Log screen, I expect that when I click on the 'Whitelist' button, it adds the domain to the whitelist like it is saying it is.

Actual behavior:

After clicking on 'Whitelist', I go to the 'Whitelist' screen and can't see the URL I whitelisted from the 'Query Log' screen on there.

Steps to reproduce:

Go to 'Query Log' screen, click on a 'Whitelist' button, wait for it to finish saying it has added, then go to the 'Whitelist' screen.

Debug token provided by uploading pihole -d log:

ldacc12lnk

Troubleshooting undertaken, and/or other relevant information:

I manually added the URL to the whitelist

[PatrickTulskie]

I'm having the same problem. Also after updating from 4.x to 5.1.1, my blacklist and whitelist are both completely gone.

[ray73864]

I still have my existing whitelist, but yeah, it appears to be hit and miss since upgrading to 5.1.1.

I deleted an entry from my whitelist, visited the webpage, refreshed the query log, clicked on 'Whitelist', and this time it went into the whitelist like it was supposed to.

But other times it doesn't work at all.

[yubiuser]

Please clear your browser's cache and try again.

[BluePhoenix]

I believe this has to do with the web interface adding the entry to the old audit list location, it has been recently moved into an sqllite 3 database, instead of the audit text file it was in before.

I think this pull request might fix it... #1518 but not entirely sure, just what I found when researching why this wasn't working, as I noticed the same things you are mentioning. The item gets added to the whitelist but doesn't disappear from the audit list.

[K-Ko]

Whitelist and blacklist also empty here and load fails with

.../admin/groups-domains.php?type=black

id=domainsTable - Ajax error

1st call works:
Request URL: .../admin/scripts/pi-hole/php/groups.php
Request Method: POST
Status Code: 200 OK

But 2nd one not
Request URL: .../admin/scripts/pi-hole/php/groups.php
Request Method: POST
Status Code: 500 Internal Server Error

After this, the frontend ist stuck, need lighttpd to restart

[pralor-bot]

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/whitelist-button-doesnt-work-in-query-log-page/35695/24

[sgtlaggy]

Bumping this, as I just ran into it. In certain cases, it's blacklisting instead of whitelisting items.
Here is where it should be whitelisting, but it's only whitelisting cases 1, 4, and 5. However, looking here, 9-11 also have whitelist buttons.
I'm considering opening a PR to also check for 9, but avoid touching 10 and 11, as I'm not sure what should be done about items already on the blacklist, and I'm not very proficient in JS.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

[yubiuser]

This should have been fixed by #1578