Datatables on main index #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll merge this to an alpha branch to test out! |
|
awesome, glad to contribute |
|
This looks pretty cool. Thanks! |
|
Right now the only issue I see is that the php takes a long time to load all of the DNS records. Maybe limit it to loading the first 500 or so? |
|
ive actually just started noticing that as well on my own system as the query numbers get large, to do that would i just do as i did before, make the changes and then create a new pull request? |
|
You can just continue to make changes and push to this PR, it will update the PR as you make your pushes. |
|
We have this implemented in #25, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add datatables on main index with the actual dns entries being queried and being blocked.
makes datables responsive as well.
see screenshot below...
