Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale axes to integer #2196

Merged
merged 1 commit into from
May 1, 2022
Merged

Scale axes to integer #2196

merged 1 commit into from
May 1, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented May 1, 2022

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • [] I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Prevents the timeline charts at the dashboard to scale the y-axis with floating-point numbers.

Bildschirmfoto zu 2022-05-01 17-03-53
Bildschirmfoto zu 2022-05-01 17-04-26

How does this PR accomplish the above?:

Use precision from https://www.chartjs.org/docs/2.9.4/axes/cartesian/linear.html

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested review from rdwebdesign and a team May 1, 2022 18:03
@DL6ER DL6ER merged commit 772944f into devel May 1, 2022
@DL6ER DL6ER deleted the integer_only branch May 1, 2022 18:18
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants