Settings page for the web UI

[DL6ER]

Changes proposed in this pull request:

• Add a settings page to the web UI

To be able to use it you will have to check out the branch websettingspage for pi-hole core. In the top row you see some debug output. I will remove this at some later stage.

Screenshot:

Does not work without pi-hole/pi-hole#976

@pi-hole/dashboard

[C4Wiz]

the toggles for the blocking page do not work, nor do the admin buttons

[dschaper]

WIP = Work In Progress

[DL6ER]

@C4Wiz The options where I haven't implemented the backend yet are marked as disabled simply because nothing would happen

[C4Wiz]

yea, sorry, i jumped the gun....my bad

[DL6ER]

@C4Wiz Try again 😉

[PromoFaux]

Pefect.

I'm unable to test the DHCP settings currently. Someone else may want to check that before approval

[PromoFaux]

Approved

[C4Wiz]

unticking the boxed layout option and clicking save changes the layout, but when navigating to the main page the layout returns to boxed!

[PromoFaux]

@C4Wiz, this may have been fixed in another branch. Are you on the devel branch?

[C4Wiz]

yes i am

[DL6ER]

Can you tell me what version is in your footer?

[C4Wiz]

[DL6ER]

What happens if you visit the Settings page, again? Is the box selected although you deactivated it before?

[C4Wiz]

yes

[DL6ER]

Unfortunately, I cannot confirm this on the very same git versions as you are.

Please try the following:

• Change it on the web UI, does WEBUIBOXEDLAYOUT= in /etc/pihole/setupVars.conf change?
• Try switching if off using: sudo pihole -a layout traditional, does /etc/pihole/setupVars.conf change?

[C4Wiz]

there is no WEBUIBOXEDLAYOUT= in the setupVars.conf

that command does nothing

[DL6ER]

Then your scripts seem outdated. You have to run pihole -r after pulling changes from the development branch of the core repository.

[C4Wiz]

oh sorry, i was not aware the pihole -r was required, running now

[DL6ER]

Yes, they are installed on an update, while installing means copying with proper permissions. You just updated the scripts in the local repository but not the ones at the installation targets /usr/local/bin/ and /opt/pihole

[C4Wiz]

gotcha, kinda new to git...confirmed it is now working properly. and i learned something new!

[DL6ER]

Every one of us has benefited. You learned something new and we know that it works for you as well.

[C4Wiz]

you guys are awsome!